feat: cli command for enabling or disabling an extension - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.36k stars 835 forks source link

feat: cli command for enabling or disabling an extension #3816

Closed imorland closed 1 year ago

imorland commented 1 year ago

Changes proposed in this pull request: Adds a new CLI command to enable toggling of a given extension.

Usage:

 php flarum extension:enable blomstra-turnstile

 php flarum extension:disable blomstra-turnstile

Reviewers should focus on:

Screenshot

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

Required changes:

[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)

SychO9 commented 1 year ago

Are we planning to eventually add some kind of "enable/disable all" to this, or would that (and bisection) be a separate command?

The enabl/disable all could be eventually part of this same command I think, we'd probably use an all argument or --all option.

The bisect should be its own command imo