fix(bbcode): highlight.js does not work after changing post content - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.36k stars 835 forks source link

fix(bbcode): highlight.js does not work after changing post content #3817

Closed SychO9 closed 1 year ago

SychO9 commented 1 year ago

Fixes #3794

Changes proposed in this pull request:

Explicitly applies hljs after the post content has been updated.
The relevant commit is https://github.com/flarum/framework/commit/8081e9b90ce34ea060bf9f051436c9cca63e2c8d the second one is just a re-organization of the code.

Necessity

[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

Required changes:

[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)

SychO9 commented 1 year ago

Agreed.