fix(testing): always clear cache in integration test's tearDown - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.28k stars 826 forks source link

fix(testing): always clear cache in integration test's tearDown #3818

Closed n-peugnet closed 1 year ago

n-peugnet commented 1 year ago

Changes proposed in this pull request:

This prevent integration tests from interacting between each other through the cache. See https://github.com/flarum/framework/issues/3663#issuecomment-1531646474.

Necessity

[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?

Confirmed

[x] Frontend changes: tested on a local Flarum installation.
[x] Backend changes: tests are green (run composer test).
[x] Core developer confirmed locally this works as intended.
[x] Tests have been added, or are not appropriate here.