search

flarum / framework

Simple forum software for building great communities.
http://flarum.org/
6.36k stars 835 forks source link

`authenticatedAs` option does not work with `/admin` routes in integration tests #3834

Closed n-peugnet closed 11 months ago

n-peugnet commented 1 year ago

Current Behavior

While trying to test a new admin route created like this:

(new Extend\Routes('admin'))
    ->get('/highlight-preview', 'club-1-server-side-highlight.preview', PreviewController::class),

Testing it like this:

$response = $this->send(
    $this->request('GET', '/admin/highlight-preview', ['authenticatedAs' => 1])
);
$this->assertEquals(200, $response->getStatusCode());

Results in this failure:

Failed asserting that 403 matches expected 200.

After a quick debug session, it seems that despite the token is created and the header is added, $actor always ends up beeing a new Guest.

Steps to Reproduce

git clone https://github.com/club-1/flarum-ext-server-side-highlight
cd flarum-ext-server-side-highlight
git checkout 6e01255461a606440e1bfdae2307356fc99bf049
make testintegration

Expected Behavior

Actor should be set as the correct one.

Screenshots

No response

Environment

Composer versions ```console $ composer show axy/backtrace 2.0.0 Tracing in PHP brick/math 0.11.0 Arbitrary-precision arithmetic library components/font-awesome 5.15.4 Font Awesome, the iconic SVG, font, and CSS framework. composer/ca-bundle 1.3.5 Lets you find a path to the system CA bundle, and includes a ... composer/class-map-generator 1.0.0 Utilities to scan PHP code and generate class maps. composer/composer 2.5.5 Composer helps you declare, manage and install dependencies o... composer/metadata-minifier 1.0.0 Small utility library that handles metadata minification and ... composer/pcre 3.1.0 PCRE wrapping library that offers type-safe preg_* replacements. composer/semver 3.3.2 Semver library that offers utilities, version constraint pars... composer/spdx-licenses 1.5.7 SPDX licenses list and validation library. composer/xdebug-handler 3.0.3 Restarts a process without Xdebug. dflydev/dot-access-data v3.0.2 Given a deep data structure, access data by dot notation. dflydev/fig-cookies v3.0.0 Cookies for PSR-7 HTTP Message Interface. doctrine/cache 2.2.0 PHP Doctrine Cache library is a popular cache implementation ... doctrine/dbal 2.13.9 Powerful PHP database abstraction layer (DBAL) with many feat... doctrine/deprecations v1.0.0 A small layer on top of trigger_error(E_USER_DEPRECATED) or P... doctrine/event-manager 1.2.0 The Doctrine Event Manager is a simple PHP event system that ... doctrine/inflector 2.0.6 PHP Doctrine Inflector is a small library that can perform st... doctrine/instantiator 2.0.0 A small, lightweight utility to instantiate objects in PHP wi... doctrine/lexer 1.2.3 PHP Doctrine Lexer parser library that can be used in Top-Dow... dragonmantank/cron-expression v3.3.2 CRON for PHP: Calculate the next or previous run date and det... egulias/email-validator 2.1.25 A library for validating emails against several RFCs fig/http-message-util 1.1.5 Utility classes and constants for use with PSR-7 (psr/http-me... filp/whoops 2.15.2 php error handling for cool kids flarum/core v1.7.2 Delightfully simple forum software. flarum/phpstan v1.8.0 Flarum PHPStan extension flarum/testing v1.7.0 Automated testing infrastructure for Flarum core and extensions. franzl/whoops-middleware 2.0.0 PSR-15 compatible middleware for Whoops, the pretty error han... guzzlehttp/guzzle 7.5.1 Guzzle is a PHP HTTP client library guzzlehttp/promises 1.5.2 Guzzle promises library guzzlehttp/psr7 2.5.0 PSR-7 message implementation that also provides common utilit... hamcrest/hamcrest-php v2.0.1 This is the PHP port of Hamcrest Matchers illuminate/bus v8.83.27 The Illuminate Bus package. illuminate/cache v8.83.27 The Illuminate Cache package. illuminate/collections v8.83.27 The Illuminate Collections package. illuminate/config v8.83.27 The Illuminate Config package. illuminate/console v8.83.27 The Illuminate Console package. illuminate/container v8.83.27 The Illuminate Container package. illuminate/contracts v8.83.27 The Illuminate Contracts package. illuminate/database v8.83.27 The Illuminate Database package. illuminate/events v8.83.27 The Illuminate Events package. illuminate/filesystem v8.83.27 The Illuminate Filesystem package. illuminate/hashing v8.83.27 The Illuminate Hashing package. illuminate/http v8.83.27 The Illuminate Http package. illuminate/macroable v8.83.27 The Illuminate Macroable package. illuminate/mail v8.83.27 The Illuminate Mail package. illuminate/pipeline v8.83.27 The Illuminate Pipeline package. illuminate/queue v8.83.27 The Illuminate Queue package. illuminate/session v8.83.27 The Illuminate Session package. illuminate/support v8.83.27 The Illuminate Support package. illuminate/translation v8.83.27 The Illuminate Translation package. illuminate/validation v8.83.27 The Illuminate Validation package. illuminate/view v8.83.27 The Illuminate View package. intervention/image 2.7.2 Image handling and manipulation library with support for Lara... jaybizzle/crawler-detect v1.2.114 CrawlerDetect is a PHP class for detecting bots/crawlers/spid... jenssegers/agent v2.6.4 Desktop/mobile user agent parser with support for Laravel, ba... justinrainbow/json-schema 5.2.12 A library to validate a json schema. laminas/laminas-diactoros 2.25.2 PSR HTTP Message implementations laminas/laminas-escaper 2.12.0 Securely and safely escape HTML, HTML attributes, JavaScript,... laminas/laminas-httphandlerrunner 2.6.0 Execute PSR-15 RequestHandlerInterface instances and emit res... laminas/laminas-stratigility 3.9.0 PSR-7 middleware foundation for building and dispatching midd... laravel/serializable-closure v1.3.0 Laravel Serializable Closure provides an easy and secure way ... league/commonmark 2.4.0 Highly-extensible PHP Markdown parser which fully supports th... league/config v1.2.0 Define configuration arrays with strict schemas and access va... league/flysystem 1.1.10 Filesystem abstraction: Many filesystems, one API. league/mime-type-detection 1.11.0 Mime-type detection for Flysystem matthiasmullie/minify 1.3.70 CSS & JavaScript minifier, in PHP. Removes whitespace, strips... matthiasmullie/path-converter 1.1.3 Relative path converter middlewares/base-path v2.1.0 Middleware to remove the prefix from the uri path of the requ... middlewares/base-path-router v2.0.1 A PSR-15 middleware for hierarchical dispatching based on pat... middlewares/request-handler v2.0.2 Middleware to execute request handlers middlewares/utils v3.3.0 Common utils for PSR-15 middleware packages mobiledetect/mobiledetectlib 2.8.41 Mobile_Detect is a lightweight PHP class for detecting mobile... mockery/mockery 1.5.1 Mockery is a simple yet flexible PHP mock object framework monolog/monolog 1.27.1 Sends your logs to files, sockets, inboxes, databases and var... myclabs/deep-copy 1.11.1 Create deep copies (clones) of your objects nesbot/carbon 2.66.0 An API extension for DateTime that supports 281 different lan... nette/schema v1.2.3 📐 Nette Schema: validating data structures against a given... nette/utils v4.0.0 🛠 Nette Utils: lightweight utilities for string & array m... nikic/fast-route v0.6.0 Fast request router for PHP nikic/php-parser v4.15.4 A PHP parser written in PHP nunomaduro/larastan 1.0.4 Larastan - Discover bugs in your code without running it. A p... opis/closure 3.6.3 A library that can be used to serialize closures (anonymous f... phar-io/manifest 2.0.3 Component for reading phar.io manifest information from a PHP... phar-io/version 3.2.1 Library for handling version information and constraints phpstan/phpstan 1.8.11 PHPStan - PHP Static Analysis Tool phpstan/phpstan-deprecation-rules 1.0.0 PHPStan rules for detecting usage of deprecated classes, meth... phpstan/phpstan-mockery 1.1.0 PHPStan Mockery extension phpstan/phpstan-phpunit 1.2.2 PHPUnit extensions and rules for PHPStan phpunit/php-code-coverage 9.2.26 Library that provides collection, processing, and rendering f... phpunit/php-file-iterator 3.0.6 FilterIterator implementation that filters files based on a l... phpunit/php-invoker 3.1.1 Invoke callables with a timeout phpunit/php-text-template 2.0.4 Simple template engine. phpunit/php-timer 5.0.3 Utility class for timing phpunit/phpunit 9.6.7 The PHP Unit Testing framework. psr/container 1.1.2 Common Container Interface (PHP FIG PSR-11) psr/event-dispatcher 1.0.0 Standard interfaces for event handling. psr/http-client 1.0.2 Common interface for HTTP clients psr/http-factory 1.0.2 Common interfaces for PSR-7 HTTP message factories psr/http-message 1.1 Common interface for HTTP messages psr/http-server-handler 1.0.2 Common interface for HTTP server-side request handler psr/http-server-middleware 1.0.2 Common interface for HTTP server-side middleware psr/log 1.1.4 Common interface for logging libraries psr/simple-cache 1.0.1 Common interfaces for simple caching ralouphie/getallheaders 3.0.3 A polyfill for getallheaders. ramsey/collection 2.0.0 A PHP library for representing and manipulating collections. ramsey/uuid 4.7.4 A PHP library for generating and working with universally uni... react/promise v2.9.0 A lightweight implementation of CommonJS Promises/A for PHP s9e/regexp-builder 1.4.6 Single-purpose library that generates regular expressions tha... s9e/sweetdom 2.1.0 Syntactic sugar for the DOM API with a focus on XSLT 1.0 temp... s9e/text-formatter 2.13.1 Multi-purpose text formatting and markup library. Plugins off... scrivo/highlight.php v9.18.1.10 Server side syntax highlighter that supports 185 languages. I... sebastian/cli-parser 1.0.1 Library for parsing CLI options sebastian/code-unit 1.0.8 Collection of value objects that represent the PHP code units sebastian/code-unit-reverse-lookup 2.0.3 Looks up which function or method a line of code belongs to sebastian/comparator 4.0.8 Provides the functionality to compare PHP values for equality sebastian/complexity 2.0.2 Library for calculating the complexity of PHP code units sebastian/diff 4.0.4 Diff implementation sebastian/environment 5.1.5 Provides functionality to handle HHVM/PHP environments sebastian/exporter 4.0.5 Provides the functionality to export PHP variables for visual... sebastian/global-state 5.0.5 Snapshotting of global state sebastian/lines-of-code 1.0.3 Library for counting the lines of code in PHP source code sebastian/object-enumerator 4.0.4 Traverses array structures and object graphs to enumerate all... sebastian/object-reflector 2.0.4 Allows reflection of object attributes, including inherited a... sebastian/recursion-context 4.0.5 Provides functionality to recursively process PHP variables sebastian/resource-operations 3.0.3 Provides a list of PHP built-in functions that operate on res... sebastian/type 3.2.1 Collection of value objects that represent the types of the P... sebastian/version 3.0.2 Library that helps with managing the version number of Git-ho... seld/jsonlint 1.9.0 JSON Linter seld/phar-utils 1.2.1 PHAR file format utilities, for when PHP phars you up seld/signal-handler 2.0.1 Simple unix signal handler that silently fails where signals ... swiftmailer/swiftmailer v6.3.0 Swiftmailer, free feature-rich PHP mailer sycho/codecs-base64vlq 2.0.0 Codec for VLQ (variable-length quantity) Base64 algorithm sycho/errors 3.0.0 Exceptions in PHP sycho/json-api v0.5.2 JSON-API responses in PHP sycho/sourcemap 2.0.0 Work with JavaScript/CSS Source Map symfony/config v5.4.21 Helps you find, load, combine, autofill and validate configur... symfony/console v5.4.23 Eases the creation of beautiful and testable command line int... symfony/css-selector v6.2.7 Converts CSS selectors to XPath expressions symfony/deprecation-contracts v3.2.1 A generic function and convention to trigger deprecation notices symfony/error-handler v6.2.10 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.4.22 Provides tools that allow your application components to comm... symfony/event-dispatcher-contracts v3.2.1 Generic abstractions related to dispatching event symfony/filesystem v6.2.10 Provides basic utilities for the filesystem symfony/finder v5.4.21 Finds files and directories via an intuitive fluent interface symfony/http-foundation v5.4.23 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.4.23 Provides a structured process for converting a Request into a... symfony/mime v5.4.23 Allows manipulating MIME messages symfony/polyfill-ctype v1.27.0 Symfony polyfill for ctype functions symfony/polyfill-iconv v1.27.0 Symfony polyfill for the Iconv extension symfony/polyfill-intl-grapheme v1.27.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-idn v1.27.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 func... symfony/polyfill-intl-messageformatter v1.27.0 Symfony polyfill for intl's MessageFormatter class and relate... symfony/polyfill-intl-normalizer v1.27.0 Symfony polyfill for intl's Normalizer class and related func... symfony/polyfill-mbstring v1.27.0 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.27.0 Symfony polyfill backporting some PHP 7.2+ features to lower ... symfony/polyfill-php73 v1.27.0 Symfony polyfill backporting some PHP 7.3+ features to lower ... symfony/polyfill-php80 v1.27.0 Symfony polyfill backporting some PHP 8.0+ features to lower ... symfony/polyfill-php81 v1.27.0 Symfony polyfill backporting some PHP 8.1+ features to lower ... symfony/process v5.4.23 Executes commands in sub-processes symfony/service-contracts v2.5.2 Generic abstractions related to writing services symfony/string v6.2.8 Provides an object-oriented API to strings and deals with byt... symfony/translation v5.4.22 Provides tools to internationalize your application symfony/translation-contracts v2.5.2 Generic abstractions related to translation symfony/var-dumper v6.2.10 Provides mechanisms for walking through any arbitrary PHP var... symfony/yaml v5.4.23 Loads and dumps YAML files theseer/tokenizer 1.2.1 A small library for converting tokenized PHP source code into... tijsverkoyen/css-to-inline-styles 2.2.6 CssToInlineStyles is a class that enables you to convert HTML... voku/portable-ascii 1.6.1 Portable ASCII library - performance optimized (ascii) string... webmozart/assert 1.11.0 Assertions to validate method input/output with nice error me... wikimedia/less.php v3.2.1 PHP port of the LESS processor ```

Output of php flarum info

No response

Possible Solution

No response

Additional Context

No response