flarum / framework

Simple forum software for building great communities.
http://flarum.org/
6.27k stars 826 forks source link

proof of concept illuminate http #3865

Open SychO9 opened 1 year ago

SychO9 commented 1 year ago

I've stopped here where we have successful tests and a mostly working app.

What is left

Nice to have

Chores


Architectural changes Here is a diagram that explains how this changes the base architecture

boot

Review To make it easier reviewing the changes, here is what you should look at and ignore

Ignore: All Tests changes

Focus On: Application, SiteInterface, Server, Middlewares, Controllers, Router, RequestUtil, ExceptionHandler, HandleErrors, UrlGenerator, routes.php files. Service Providers (Forum, Admin, API).

Do we want these changes

The case for no

The case for Yes

tankerkiller125 commented 1 year ago

There is a PSR-7 middleware abstraction, but it's not ideal. https://github.com/jshannon63/psr7middleware but that's the only "potential workaround for a NO item".