feat: make page structure customizable across different pages - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.36k stars 835 forks source link

feat: make page structure customizable across different pages #3867

Closed SychO9 closed 1 year ago

SychO9 commented 1 year ago

Closes #3866

Changes proposed in this pull request:

Introduces a new forum PageStructure component that can be used from within a page component.
Changes all our current forum pages to use said component.
The new component will allow easier customization of the page structure (as long as extensions also use this component).

Some before and afters	Before	After

Necessity

[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?

Confirmed

[x] Frontend changes: tested on a local Flarum installation.
[x] Backend changes: tests are green (run composer test).
[x] Core developer confirmed locally this works as intended.
[x] Tests have been added, or are not appropriate here.

https://github.com/flarum/docs/pull/462

SychO9 commented 1 year ago

I'll merge all of these theming-related PRs into a separae dev-theming-improvements branch so that they can still be reviewed before merging this new branch into 2.x (I need to continue building on top of all the work done so far).