chore: use flexbox in dropdowns and SplitDropdown for subscriptions - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.27k stars 826 forks source link

chore: use flexbox in dropdowns and SplitDropdown for subscriptions #3874

Closed SychO9 closed 1 year ago

SychO9 commented 1 year ago

Part of https://github.com/flarum/issue-archive/issues/355

Changes proposed in this pull request:

Uses flexbox and grid in dropdown components
Cleans up the subscription's dropdown menu by actually using the SplitDropdown from core (fixes https://github.com/flarum/issue-archive/issues/217)
For convenience, splits out a new DetailedDropdownItem component into core.

The changed areas (no visual changes) Screenshot from 2023-08-28 11-56-07

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

SychO9 commented 1 year ago

ref: https://github.com/flarum/framework/pull/3867#issuecomment-1697512660