chore: normalize form semantics - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.36k stars 835 forks source link

chore: normalize form semantics #3877

Closed SychO9 closed 1 year ago

SychO9 commented 1 year ago

Fixes https://github.com/flarum/issue-archive/issues/106

Changes proposed in this pull request:

Normalizes the semantics of the forms we use (Form Form-group FieldSet) and uses flexbox/grid to organize elements.

Reviewers should focus on:

There are no visual changes from before. These changes are more convenient when customizing the styling and building more similar structures.

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

SychO9 commented 1 year ago

ref https://github.com/flarum/framework/pull/3867#issuecomment-1697512660