Extracts an abstract HeaderDropdown from NotificationsDropdown.
Extracts a HeaderList from NotificationList.
Extracts a HeaderListItem from NotificationList's Notification.
These were extracted based on the fact they're reused in the flags extension and some other ecosystem extensions.
This allows an explicit separation between the notification specific component and what can be reused. Simplifies customization and extensibility.
Necessity
[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?
Confirmed
[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.
SychO9
commented
1 year ago
Fixes https://github.com/flarum/issue-archive/issues/202
Changes proposed in this pull request:
HeaderDropdownfromNotificationsDropdown.HeaderListfromNotificationList.HeaderListItemfromNotificationList'sNotification.These were extracted based on the fact they're reused in the flags extension and some other ecosystem extensions. This allows an explicit separation between the notification specific component and what can be reused. Simplifies customization and extensibility.
Necessity
Confirmed
composer test).