Changes proposed in this pull request:
A group of minor changes (see each commit). Mostly housekeeping changes with one fix.
The icon and avatar helpers are converted to actual components. Which allows extensions to modify their output where it wasn't possible before (customization/extensibility).
Drops hardcoded variables in t LESS code for CSS variables which are more flexible for design work.
Cleans up the code for inconsistent layouts.
Necessity
[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?
Confirmed
[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.
Required changes:
[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)
SychO9
commented
12 months ago
Changes proposed in this pull request: A group of minor changes (see each commit). Mostly housekeeping changes with one fix.
iconandavatarhelpers are converted to actual components. Which allows extensions to modify their output where it wasn't possible before (customization/extensibility).LESScode for CSS variables which are more flexible for design work.Necessity
Confirmed
composer test).Required changes: