feat: reusable `UploadImageButton` component - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.27k stars 826 forks source link

feat: reusable `UploadImageButton` component #3882

Closed SychO9 closed 11 months ago

SychO9 commented 12 months ago

Changes proposed in this pull request:

Converts the components to TypeScript.
Refactors the UploadImgeButton component to allow reusing it in different contexts/other extensions.
Adds a new setting type image-upload that auto uses the refactored component.

Screenshot Screenshot from 2023-09-13 18-53-51

Screenshot from 2023-09-13 18-53-58

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

Required changes:

[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)

SychO9 commented 12 months ago

ref: https://github.com/flarum/framework/pull/3867#issuecomment-1697512660