refactor: move gambits to frontend - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.27k stars 826 forks source link

refactor: move gambits to frontend #3885

Closed SychO9 closed 11 months ago

SychO9 commented 11 months ago

Part of #3884

Changes proposed in this pull request:

Moves gambits to a frontend implementation where they are converted to filters.
This only works when using app.store.find to search resources.
There is still a lot of gambit concept code on the backend which will be dropped when following through other changes planned for the backend.

Necessity

[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

SychO9 commented 11 months ago

I'll merge any and all search-related PRs into a separate https://github.com/flarum/framework/pull/3893 branch so that they can still be reviewed before merging this new branch into 2.x (I need to continue building on top of all the work done so far).