feat: allow getting total search results and replacing filters - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.24k stars 828 forks source link

feat: allow getting total search results and replacing filters #3906

Closed SychO9 closed 9 months ago

SychO9 commented 9 months ago

Part of #3884 (https://github.com/flarum/framework/issues/3884#issuecomment-1773742849)

Changes proposed in this pull request:

Allows grabbing the total search results count. Useful for extensions that need this information.
Allows replacing existing filters.

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

SychO9 commented 9 months ago

I'll merge any and all search-related PRs into a separate https://github.com/flarum/framework/pull/3893 branch so that they can still be reviewed before merging this new branch into 2.x (I need to continue building on top of all the work done so far).