fix: paginated list limit hard to change - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.24k stars 828 forks source link

fix: paginated list limit hard to change #3918

Closed SychO9 closed 8 months ago

SychO9 commented 8 months ago

Fixes #3861

Changes proposed in this pull request:

This PR creates a single source of truth for the limit (page size) of API lists.
The source of truth/limit value is always from the backend controller limit. That way, changing the limit there affects the rest, even frontend listings.

Necessity

[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?

Confirmed

[x] Frontend changes: tested on a local Flarum installation.
[x] Backend changes: tests are green (run composer test).
[x] Core developer confirmed locally this works as intended.
[x] Tests have been added, or are not appropriate here.