chore: extract `FormModal` from `Modal` - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.24k stars 828 forks source link

chore: extract `FormModal` from `Modal` #3922

Closed SychO9 closed 8 months ago

SychO9 commented 8 months ago

Changes proposed in this pull request:

The current modal component always assumes the contents are part of a form, and therefore its typings require an onsubmit method be filled.
The PR extracts a FormModal instead to have a clear separation of read only modals and action modals.

Necessity

[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?

Confirmed

[x] Frontend changes: tested on a local Flarum installation.
[x] Backend changes: tests are green (run composer test).
[x] Core developer confirmed locally this works as intended.
[x] Tests have been added, or are not appropriate here.