flarum / framework

Simple forum software for building great communities.
http://flarum.org/
6.24k stars 828 forks source link

feat: improve emoji autocomplete #3923

Closed SychO9 closed 8 months ago

SychO9 commented 8 months ago

Changes proposed in this pull request:

Before image

After image image

Necessity

Confirmed

dsevillamartin commented 8 months ago

Could it be made so the name of the currently selected icon shows up in either placeholder or a tooltip? That way the name can be learned, as otherwise one would need to guess or keep selecting from the autocomplete every time. I see the alt attribute on the image, not sure if anything else would be better or helpful. Just a thought.

Otherwise, I like the changes! :+1:

SychO9 commented 8 months ago

@dsevillamartin it also has tooltips if that's you mean

image

dsevillamartin commented 8 months ago

@SychO9 Oh, I did not see the code. Forgot how tooltips worked nowadays for a sec. :+1:

imorland commented 8 months ago

@SychO9 if you can take care of the conflict, this is ready to merge :)