Closed iPurpl3x closed 8 months ago
@SychO9 can you explain why this got closed?
@iPurpl3x I would guess because it's targetting 1.x
? Other than fixes, 1.x
is more or less in feature freeze. I'm sure if you could retarget for 2.x
we could accept this change 🤔
I'll wait to see what @SychO9 thinks also...
I deleted the 1.x
branch to replace it with another to cleanup a few commits when working on the extension manager which is what seems to have auto closed this on delete.
reopening but we are pretty much only patching critical issues for 1.x to focus on 2.x development. We could include this in a patch should anything else (or more fixes) turn up for core as well but we unfortunately don't intend to make a new patch for every 1.x PR 🙏🏼, I hope you understand that just wouldn't be feasible.
Changes proposed in this pull request:
animateHide
function to ensure themodalClosing
flag is reset. This change aims to prevent potential issues where a modal could become unresponsive if themodalClosing
flag remains set totrue
.Reviewers should focus on:
animateHide
function.QA
Necessity
Confirmed