perf(flags): add pagination to flags list - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.24k stars 828 forks source link

perf(flags): add pagination to flags list #3931

Closed OrdinaryJellyfish closed 8 months ago

OrdinaryJellyfish commented 8 months ago

Fixes #3787

Changes proposed in this pull request:

Adds pagination to flags list

Reviewers should focus on:

If the pagination works properly
If flags are ordered properly

Screenshot

QA

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[x] Frontend changes: tested on a local Flarum installation.
[x] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[x] Tests have been added, or are not appropriate here.