chore: improve debugging experience - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.24k stars 828 forks source link

chore: improve debugging experience #3944

Closed SychO9 closed 6 months ago

SychO9 commented 7 months ago

Changes proposed in this pull request:

Auto displays the error modal with evaluated var dumper output when the API returns 500 and we are in debugging mode.
This improves the development/debugging experience for developers

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

Required changes:

[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)

SychO9 commented 7 months ago

already is 👍🏼

https://github.com/flarum/framework/blob/2.x/framework/core/composer.json#L98 https://github.com/flarum/framework/blob/2.x/composer.json#L172

imorland commented 7 months ago

🤦‍♂️