flarum / framework

Simple forum software for building great communities.
http://flarum.org/
6.23k stars 830 forks source link

[1.x] fix: reset admin page save button in catch handler #3963

Open YUCLing opened 5 months ago

YUCLing commented 5 months ago

Fixes #3962

Changes proposed in this pull request: Add a catch handler to saveSettings() to reset admin page's save button state.

Reviewers should focus on: Should a newly added function that only sets loading to false be created.

Screenshot No much changes will be shown to users.

QA Create a Saving event listener and throw an exception to create a saving error.

Necessity

Confirmed

Required changes:

YUCLing commented 3 months ago

Should I also create a PR to fix this in 2.0?