Open YUCLing opened 5 months ago
Fixes #3962
Changes proposed in this pull request: Add a catch handler to saveSettings() to reset admin page's save button state.
saveSettings()
Reviewers should focus on: Should a newly added function that only sets loading to false be created.
loading
false
Screenshot No much changes will be shown to users.
QA Create a Saving event listener and throw an exception to create a saving error.
Saving
Necessity
Confirmed
composer test
Required changes:
Should I also create a PR to fix this in 2.0?
Fixes #3962
Changes proposed in this pull request: Add a catch handler to
saveSettings()
to reset admin page's save button state.Reviewers should focus on: Should a newly added function that only sets
loading
tofalse
be created.Screenshot No much changes will be shown to users.
QA Create a
Saving
event listener and throw an exception to create a saving error.Necessity
Confirmed
composer test
).Required changes: