fix(tags): Edit tags icon fontawesome url to v5

[dian-kaagman]

Fixes #0000 (no issue)

Changes proposed in this pull request: The Fontawesome url referred to the newest icons overview, since the tags extension only supports v5 icons it's confusing for admin users why some icons don't work. The url for supported icons is: https://fontawesome.com/v5/icons?m=free.

Reviewers should focus on:

Screenshot

QA

Necessity

• [X] Has the problem that is being solved here been clearly explained?
• [X] If applicable, have various options for solving this problem been considered?
• [ ] For core PRs, does this need to be in core, or could it be in an extension?
• [X] Are we willing to maintain this for years / potentially forever?

Confirmed

• [X] Frontend changes: tested on a local Flarum installation.
• [ ] Backend changes: tests are green (run composer test).
• [ ] Core developer confirmed locally this works as intended.
• [ ] Tests have been added, or are not appropriate here.

[luceos]

Although this PR makes a lot of sense, I think we need to aim to include FA 6 with 2.x. And this link, with the PR targeting 2.x, would as such then be incorrect. Maybe this change is best made to main branch instead.

My apologies for the nitpick @dian-kaagman ; je bijdrage is alsnog erg gewaardeerd 👍

[SychO9]

Thank you for the PR and sorry for the delayed response! 2.x now supports FA v6 #4020. But the link could still use updating though to:

https://fontawesome.com/search?o=r&m=free so that the page is actually the search for free icons one.

@dian-kaagman would you like to make that change?

[imorland]

Implemented via https://github.com/flarum/framework/pull/4038, closing this, but thank you for your efforts here