Closed DavideIadeluca closed 1 month ago
If you are okay with this change, I'm happy to open the same PR against 1.x
.
Thanks for the PR! could you please remove the dist files from the PR, maybe if you branch off the commit in question from your main(2.x) branch to prevent github actions from generating dist files.
Feel free to PR to 1.x as well.
Superseded by #3988
Fixes #0000
Changes proposed in this pull request: Allow custom GitHub Actions runner to be defined in the reusable frontend & backend workflows. This allows third-party vendors to optionally pass a new input
runner_type
which specifies on which machine the jobs are being run (be it a custom GitHub-hosted runner or a self-hosted one).Hypothetical example of a calling workflow:
It's important to note that this new input is optional and will default to
ubuntu-latest
if not defined by the calling workflow.Reviewers should focus on:
Screenshot
QA
Necessity
Confirmed
composer test
).Required changes: