flarum / framework

Simple forum software for building great communities.
http://flarum.org/
6.39k stars 834 forks source link

feat: add option for filtering read stickied on all discussions page #3994

Closed adrianmccay closed 6 months ago

adrianmccay commented 6 months ago

Changes proposed in this pull request: Firstly, apologies if you are not taking PR's for 1.x or if this is just not something that would be considered. I can create a third party extension if that is a better option.

As per discussion on Flarum Discuss - https://discuss.flarum.org/d/34607-flarum-do-perform-some-automated-update For some, the stickied posts dropping down the order on "All Discusisons" like a non-stickied post when the discussion has been read is not an expected behaviour. I have added a simple on/off option which defaults to the existing behaviour. With the switch on, the read discussions on "All Discussions" are not treated as stickied. With the switch off, all stickied posts remain stickied on "All Discussions" regardless of their read status.

Reviewers should focus on: n/a

Screenshot Settings Settings page

Default/turned on Settings page

Turned off Settings page

QA

  1. On a forum with a heap of discussions, sticky a few random ones
  2. Mark some at the top as "read" - refresh "All Discussions" page to see those discussions drop down the list
  3. Switch the option Filter read from stickied on All Discussions page off
  4. See all stickied discussions at the top of "All Discussions" page

Necessity

Confirmed

Required changes:

adrianmccay commented 6 months ago

@SychO9 yep, no worries!