Changes proposed in this pull request:
Firstly, apologies if you are not taking PR's for 1.x or if this is just not something that would be considered. I can create a third party extension if that is a better option.
As per discussion on Flarum Discuss - https://discuss.flarum.org/d/34607-flarum-do-perform-some-automated-update
For some, the stickied posts dropping down the order on "All Discusisons" like a non-stickied post when the discussion has been read is not an expected behaviour. I have added a simple on/off option which defaults to the existing behaviour. With the switch on, the read discussions on "All Discussions" are not treated as stickied. With the switch off, all stickied posts remain stickied on "All Discussions" regardless of their read status.
Reviewers should focus on:
n/a
Screenshot
Settings
Default/turned on
Turned off
QA
On a forum with a heap of discussions, sticky a few random ones
Mark some at the top as "read" - refresh "All Discussions" page to see those discussions drop down the list
Switch the option Filter read from stickied on All Discussions page off
See all stickied discussions at the top of "All Discussions" page
Necessity
[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?
Confirmed
[x] Frontend changes: tested on a local Flarum installation.
[x] Backend changes: tests are green (run composer test).
[x] Core developer confirmed locally this works as intended.
[x] Tests have been added, or are not appropriate here.
Required changes:
[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)
Changes proposed in this pull request: Firstly, apologies if you are not taking PR's for 1.x or if this is just not something that would be considered. I can create a third party extension if that is a better option.
As per discussion on Flarum Discuss - https://discuss.flarum.org/d/34607-flarum-do-perform-some-automated-update For some, the stickied posts dropping down the order on "All Discusisons" like a non-stickied post when the discussion has been read is not an expected behaviour. I have added a simple on/off option which defaults to the existing behaviour. With the switch on, the read discussions on "All Discussions" are not treated as stickied. With the switch off, all stickied posts remain stickied on "All Discussions" regardless of their read status.
Reviewers should focus on: n/a
Screenshot Settings
Default/turned on
Turned off
QA
Filter read from stickied on All Discussions
page offNecessity
Confirmed
composer test
).Required changes: