fix: new webpack config doesn't work on windows - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.39k stars 834 forks source link

fix: new webpack config doesn't work on windows #4030

Closed YUCLing closed 2 months ago

YUCLing commented 2 months ago

Fixes #0000

Changes proposed in this pull request: This PR fixes the 2.0's webpack build on Windows by replacing \ separator to /.

Reviewers should focus on: Will this way of solving it cause new issues

Screenshot

QA Run webpack build on Windows to check if it's working well.

Necessity

[ ] Has the problem that is being solved here been clearly explained?
[ ] If applicable, have various options for solving this problem been considered?
[ ] For core PRs, does this need to be in core, or could it be in an extension?
[ ] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

Required changes:

[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)