flarum / framework

Simple forum software for building great communities.
http://flarum.org/
6.39k stars 834 forks source link

fix: usage of aria-hidden=false might cause inconsistent behavior #4074

Closed YUCLing closed 1 month ago

YUCLing commented 1 month ago

Fixes #4014

Changes proposed in this pull request: Replace all usage of aria-hidden=false with removing the attribute instead.

Reviewers should focus on:

Screenshot

QA Check if aria-hidden=false is still used in DOM tree.

Necessity

Confirmed

Required changes:

YUCLing commented 1 month ago

seems like it can end up being false too

I just confirmed it, using false boolean value seems to remove the whole attribute in Mithril.

hollsk commented 1 month ago

Thanks @YUCLing (and @SychO9)! 😄