search

flarum / issue-archive

0 stars 0 forks source link

Composer modal conflict with simple html header #123

Open justoverclockl opened 3 years ago

justoverclockl commented 3 years ago

Bug Report

https://streamable.com/1np2ph

Composer modal conflict with simple html header

it works without html of my custom header, any solution?

my html code

<link href="https://fonts.googleapis.com/css2?family=Mukta:wght@200&display=swap" rel="stylesheet">
<header>
  <section>
  <div class="line">
    <div class="logo">
         <a href="https://flarum.it"><img src="https://flarum.it/assets/logo-ixhepxvy.png" alt="Flarum Italia" class="logo"/></a>
        </div>
    <div class="slogan"><h1>Flarum, il software per creare community in maniera divertente.</h1></div>   
    <div id="containerbtn">
    <button onclick="location.href='https://flarum.it/t/testa-flarum'" type="button" class="myButton" type="button" id="button1">Provalo ora!</button>
    <button onclick="location.href='https://docs.flarum.org/it/'"  class="myButton" type="button" id="button2">Documentazione</button>
</div>
 </section> 
</header>
askvortsov1 commented 3 years ago

Interesting, the code that fixed flarum/framework#2683 (https://github.com/flarum/core/blob/2536e495b3cbcb5b60403236188a8cca91386610/js/src/forum/components/Composer.js#L277-L277) relied on scrollTop, scrollHeight, and clientHeight on the document element; that should account for custom header stuff, unless Safari Mobile is doing something stupid as usual. I'll test this when I have time.

justoverclockl commented 3 years ago

i will receive some notification here when this will be solved? or i need to do something? not sure about this :)

matteocontrini commented 3 years ago

Yes, you're automatically subscribed to notifications for issues you create. You will receive email notifications when activity happens or when this issue is closed.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!