Now that I've seen it, I am unsure this approach makes sense without a scroll handler. When you click multiple times on "Load previous" and "Load more", which page are you expected to be "on" (reflected by the URL parameter)? I am kind of thinking it would always be the earliest one that's loaded - because the top of the page would remain the same once you refresh the page. This would mean only "Load previous" would change the URL state.
I think we can use the links from API responses instead of building URLs ourselves - that should simplify the state on the client.
- Franz https://github.com/flarum/core/pull/1829#issuecomment-601662905
For consistency with scrolling inside a discussion, the page parameter in the URL should update whenever moving up or down.
Refreshing shows (roughly) the same section (i.e. page) that you were looking at before the refresh.
- Franz https://github.com/flarum/core/pull/1829#issuecomment-612223355
Issue created from flarum/framework#1829 and flarum/framework#1820 (pts 2 & 4). flarum/framework#1820 in particular has a lot of useful discussion.
Problems:
?page=
parameterSolutions:
Comments from the PR