flarum / issue-archive

0 stars 0 forks source link

Extension settings hidden from navbar on tablet viewport #164

Open davwheat opened 3 years ago

davwheat commented 3 years ago

Bug Report

Current Behavior The extension list and settings are not visible on the tablet viewport, while they are on Desktop and Mobile.

Yes, it's possible to access these pages by going to the Dashboard and scrolling down, but this results in a very tedious experience if editing multiple extension's settings (as you need to go to the dashboard every single time). The fact that you can still get to them shouldn't be used as an excuse for not showing them in the navbar, otherwise we might as well entirely remove them from the nav on all viewports, not just tablet.

Steps to Reproduce

  1. Make your browser ~960px wide
  2. Go to admin page
  3. No extension settings are visible

Expected Behavior Extension settings would be visible at the top of the page, with other nav items

Screenshots

https://user-images.githubusercontent.com/7406822/104094256-8e83d880-5287-11eb-8186-db056b7d460e.mp4

Environment

php flarum info ``` Flarum core 0.1.0-beta.15 PHP version: 7.4.12 Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, ctype, curl, dom, fileinfo, filter, ftp, hash, iconv, json, mbstring, SPL, PDO, session, posix, readline, Reflection, standard, SimpleXML, pdo_sqlite, Phar, tokenizer, xml, xmlreader, xmlwriter, mysqlnd, apcu, bcmath, calendar, exif, gd, geoip, gettext, gmp, intl, ldap, memcached, mysqli, pcntl, pdo_mysql, pdo_sqlsrv, redis, sodium, sqlsrv, sysvmsg, tidy, timezonedb, xsl, zip, Zend OPcache +------------------------------+---------------------+------------------------------------------+ | Flarum Extensions | | | +------------------------------+---------------------+------------------------------------------+ | ID | Version | Commit | +------------------------------+---------------------+------------------------------------------+ | flarum-approval | v0.1.0-beta.15 | | | flarum-bbcode | v0.1.0-beta.15 | | | flarum-emoji | v0.1.0-beta.15 | | | flarum-lang-english | v0.1.0-beta.15 | | | flarum-flags | v0.1.0-beta.15 | | | flarum-lock | v0.1.0-beta.15 | | | flarum-markdown | v0.1.0-beta.15 | | | flarum-mentions | v0.1.0-beta.15 | | | flarum-statistics | v0.1.0-beta.15 | | | flarum-sticky | v0.1.0-beta.15 | | | flarum-subscriptions | v0.1.0-beta.15 | | | flarum-suspend | v0.1.0-beta.15 | | | flarum-tags | v0.1.0-beta.15 | | | fof-formatting | 0.3.1 | | | fof-user-bio | 0.4.1 | | | fof-ignore-users | 0.3.0 | | | bokt-cache-assets | 0.3 | | | fof-impersonate | 0.7.0 | | | fof-links | 0.5.0 | | | fof-merge-discussions | 0.5.1 | | | fof-moderator-notes | 0.4.0 | | | fof-profile-image-crop | 0.2.1 | | | fof-best-answer | dev-im/settingspage | aa8027a2d8c66056b0e3b78190234457f59bb983 | | fof-reactions | 0.5.0 | | | fof-sitemap | 0.6.0 | | | fof-byobu | 0.6.0 | | | fof-default-user-preferences | 0.3.1 | | | fof-follow-tags | 0.6.4 | | | fof-split | 0.6.0 | | | fof-upload | 0.12.1 | | | ianm-follow-users | dev-master | 8df42c5775ac61f70e4aaa08212669ed65e4b189 | +------------------------------+---------------------+------------------------------------------+ Base URL: http://localhost Installation path: /var/www Debug mode: ON Don't forget to turn off debug mode! It should never be turned on in a production system. ```
dsevillamartin commented 3 years ago

I don't know if this is intended or not, or whether it's really an issue either. The extensions are still visible through the Dashboard page, so not having the navbar list doesn't prevent the navigation to extension pages. The only functionality you miss out is seeing if they're enabled/disabled at a glance & searching through them.

Not sure how we would improve this 🤔

davwheat commented 3 years ago

It just becomes a pain to navigate through multiple extension's settings if your browser window is too small.

It's not an issue, per sé, but it's a weird stylistic choice to hide option at a viewport, in my opinion.

We wouldn't go hiding some forum navigation options at certain resolutions and say it's not an issue as you can still access them from another page.

I have no clue how this could be improved either. Adding a menu drawer would work. Maybe allowing the mobile menu on tablet viewports?

askvortsov1 commented 3 years ago

Honestly I'm not a big fan of the tablet menu view at all, it's a right pain to have to scroll right when there's a lot of items. I'd be in favor of getting rid of it in favor of just desktop and mobile.

davwheat commented 3 years ago

A lot of people online seem to share the view that tablets shows show the same view as desktop, and I'm leaning towards that too.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!