search

flarum / issue-archive

0 stars 0 forks source link

Group DiscussionListItem info items better #200

Closed dsevillamartin closed 1 year ago

dsevillamartin commented 4 years ago

Right now, flarum/tags adds an element to the left of the view count. However, tags adds it to the infoItems while the view count is hardcoded.

This causes problems when other extensions try to add elements next to the view count, e.g. fof/gamification or michaelbelgium/flarum-discussion-views.

These extensions have to move other extension's items like tag labels (by modifying margin or other means) so they don't overlap.

It would be much easier if we had a group with inline elements that was solely focused on items on the right end of the DiscussionListItem component.

We could potentially use flexbox for the DiscussionListItem so that too many elements on the right side doesn't mess up the styling (should be available in every browser Flarum supports, see https://caniuse.com/#search=flex). flex-grow on the left side would allow the right side to expand indefinitely while the left side holds the most space - without any weird JS or jQuery tricks.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

dsevillamartin commented 4 years ago

Still relevant 🙂

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

SychO9 commented 1 year ago

https://github.com/flarum/framework/pull/3868