search

flarum / issue-archive

0 stars 0 forks source link

unexpected back button behaviour on mobile (android) #208

Open z202006 opened 4 years ago

z202006 commented 4 years ago

Bug Report

Current Behavior I've provided some feedback to giffgaff's community at https://community.giffgaff.com/d/33136477-unexpected-back-button-behaviour-on-mobile and have been advised to raise an issue over here by one of giffgaff's community contributors. I've checked on the flarum's forum and it behaves the same so the issue looks like it's core to flarum.

Steps to Reproduce

  1. Go to https://discuss.flarum.org/t/feedback
  2. Click on * near the top right
  3. Hit the back button
  4. Leaves the feedback tag and goes to the page visited before that

Expected Behavior Dialog should be dismissed and original page (in this case https://discuss.flarum.org/t/feedback) should be displayed. See https://joshblog.net/2018/enabling-the-back-button-to-cancel-confirmation-dialogs-in-react-apps/ where it states ...

Users expect that dialogs, action sheets, alerts, drawers, and other pop-ups will close when the back button is pressed. This is especially true on Android (where the back button is globally available in all apps), but this behavior makes sense for any apps running in a web browser too — on both mobile and desktop. Usually, when a dialog is open, the back button should act the same as if the user had chosen the “Cancel” option. The worst thing that could happen (but it’s surprisingly common, unfortunately) is that the dialog will close and the browser will navigate away from the page that opened the dialog!

Screenshots If applicable, add screenshots to help explain your problem.

Environment

Output of "php flarum info", run this in terminal in your Flarum directory.

Possible Solution

Additional Context Add any other context about the problem here.

davwheat commented 4 years ago

Note: to reproduce, make sure you're in the mobile view.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

davwheat commented 4 years ago

Not stale :)

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

davwheat commented 3 years ago

Not stale

On Fri, 18 Dec 2020, 06:33 stale[bot], notifications@github.com wrote:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flarum/core/issues/2204#issuecomment-747898971, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYQJZR3SQYNVOIOHTZF3DTSVLZUNANCNFSM4ODML2TA .

askvortsov1 commented 3 years ago

Related to https://github.com/flarum/core/issues/835. Once this is fixed, I would like to establish common behavior for both back button systems.