search

flarum / issue-archive

0 stars 0 forks source link

Change Admin E-Mail Reset UI #210

Open tankerkiller125 opened 4 years ago

tankerkiller125 commented 4 years ago

Please take a look at https://github.com/flarum/core/pull/2113#discussion_r441532304 Notably we're looking to make it so that the admin can choose to send a reset email notification to the user or bypass it and just force reset it.

tankerkiller125 commented 4 years ago

A good first step for anyone wanting to tackle this issue would be to create some mock ups for us to go over and give feedback on.

clarkwinkelmann commented 4 years ago

Additional thing I realized just now following https://discuss.flarum.org/d/24266-admin-cannot-update-own-mail-or-set-a-password on the forums.

Currently if we let admins edit their own email, it actually results in an email change validation being sent because of the way we built the API. So this results in unexpected behavior, which might be why we were hiding the email field until now in the edit modal https://github.com/flarum/core/blob/d492579638fb52dafbfe65f1f36a95eb6047f7f3/src/User/Command/EditUserHandler.php#L76

I'd suggest maybe we create a new attribute name or even a new endpoint to request the email change with validation, that way the "normal" API endpoint can be used only for saving a new email directory.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

askvortsov1 commented 4 years ago

Not stale

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

tankerkiller125 commented 3 years ago

Shoo bot

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!