search

flarum / issue-archive

0 stars 0 forks source link

Notification of mentioned post might show the wrong discussion #216

Open matteocontrini opened 4 years ago

matteocontrini commented 4 years ago

Bug Report

Current Behavior

When sending a message in a discussion (A) that replies to a post from another discussion (B), the notification says that the reply happened in discussion B, even though it happened in discussion A.

Steps to Reproduce

  1. Create a discussion (A) with any content
  2. Log in with another user
  3. Go to discussion A, click reply and copy the content of the composer. Don't send the message
  4. Create a discussion (B) and paste the reply "code" you just copied. Send the message
  5. Observe that the user that created discussion A received a notification where the discussion name is A, while it should be B. This is especially confusing in the email notification, where it explicitly says that "{user} replied to your post in A"

Expected Behavior

The notification should show the discussion where the event happened, not the discussion where the mentioned post is, which is what is done now in the code.

https://github.com/flarum/mentions/blob/9ac08e302d01849a6252fe4339c8eb1b415a12b3/src/Notification/PostMentionedBlueprint.php#L75

Environment

This might be the same as flarum/framework#448, but that issue doesn't have a proper description so I don't understand what it actually refers to.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

matteocontrini commented 4 years ago

Still an issue

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

matteocontrini commented 4 years ago

Probably still an issue.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

stale[bot] commented 3 years ago

We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it.

matteocontrini commented 3 years ago

Still an issue.