search

flarum / issue-archive

0 stars 0 forks source link

Login via ResponseFactory (used for external auth) doesn't generate LoggedIn event #223

Open askvortsov1 opened 4 years ago

askvortsov1 commented 4 years ago

Bug Report

Current Behavior https://github.com/flarum/core/blob/master/src/Forum/Auth/ResponseFactory.php should generate a Flarum\User\Event\LoggedIn event on successful login. This code is missing.

askvortsov1 commented 4 years ago

I'm pretty sure I could fairly easily put in the LoggedIn event, but I think that this is an opportunity to consider an internal redesign of the LoginProvider login/registration flow. I'm closing this in favor of https://github.com/flarum/core/issues/1858#issuecomment-586140912.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

stale[bot] commented 4 years ago

We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it.

dsevillamartin commented 4 years ago

Still relevant.