Add hamburger button to menu on mobile topic pages

[askvortsov1]

Feature Request

Is your feature request related to a problem? Please describe. When on mobile, the hamburger menu slider button appears on tag pages, but not on topic pages. This is annoying, because the menu should be accessible on all pages.

Describe the solution you'd like Add the hamburger menu button to the right of the back-arrow on mobile for topic pages.

Justify why this feature belongs in Flarum's core, rather than in a third-party extension The solution is trivial, and increases ease-of-use for all mobile flarum users.

[franzliedke]

And again, I have my doubts here. (Sorry.) As in flarum/framework#1993, this might be intentional.

The button is a back button, as it jumps back in history (when possible). This may be different from a "conventional" hamburger / home button, as it may take us to a pre-filtered discussion list or the tags page.

IIRC, you also mentioned somewhere that having the back button is unnecessary, as it duplicates the browser back button. I believe (and we've definitely had this discussion somewhere here before), the idea is to provide a back button for e.g. standalone web apps on mobile devices (where no browser chrome is displayed, depending on the settings).

[askvortsov1]

And again, I have my doubts here. (Sorry.) As in flarum/framework#1993, this might be intentional.

No worries, discussion leads to better products!

The button is a back button, as it jumps back in history (when possible). This may be different from a "conventional" hamburger / home button, as it may take us to a pre-filtered discussion list or the tags page.

If the user gets to a discussion page via clicking from a filtered discussion list, those filters are stored in the browser's history, so the browser's back functionality (or gesture-based back buttons) should have the exact same functionality. If they don't, that's something that should be fixed in a different point (making sure that searches and filters are properly logged in history) rather than by hacking around it with a back button.

IIRC, you also mentioned somewhere that having the back button is unnecessary, as it duplicates the browser back button. I believe (and we've definitely had this discussion somewhere here before), the idea is to provide a back button for e.g. standalone web apps on mobile devices (where no browser chrome is displayed, depending on the settings).

From my understanding, most mobile devices are transitioning to more of a gesture-based system for "going back". There isn't really a virtual "back button" in most cases. Additionally, as mentioned above, gesture-based systems already have support for going back to a filtered discussion list (at least on the devices that I've tested on).

Even so, at least from my experience I can attest that it is very annoying to not have a navigation menu with links/notifs/profile/login info on some pages. As explained above, I don't see drawbacks to this change, but even if there were I think that the UX benefits of having a menu on every page significantly outweighs potential drawbacks.

[matteocontrini]

Even so, at least from my experience I can attest that it is very annoying to not have a navigation menu with links/notifs/profile/login info on some pages.

There was a proposal for fixing this in a more radical way in flarum/issue-archive#348, just for the record :)

[askvortsov1]

I like flarum/issue-archive#348 a lot, but I think this could be good as a temporary measure

[franzliedke]

Grouping the back button with the hamburger might be nice, similar to how it is grouped with the pin button when visiting a discussion page (via client-side navigation).

[askvortsov1]

https://i.imgur.com/T0K36ek.png

That's actually my first approach, although imo it felt a bit cluttered.

[tankerkiller125]

I don't think it looks that cluttered as the only thing ever in that header usually is the post number your on and the drop down for tag listings on the homepage.

[askvortsov1]

If that approach is fine with y'all, I can make a new PR?

[askvortsov1]

Could we consider this for Beta 13?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[stale[bot]]

We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it.