search

flarum / issue-archive

0 stars 0 forks source link

Opening Tag page starts partially scrolled down.. #241

Open mikejones3 opened 5 years ago

mikejones3 commented 5 years ago

Bug Report

Current Behavior From the main page of any flarum, if you click a tag on the left-hand side to go to that tag page, it opens the new page partially scrolled down...

Not sure if flarum does this on purpose or if this is a bug. Personally, I do not want it to be partially scrolled down because it either cuts out entirely the tag description or partially. I want users to see this tag description.

Steps to Reproduce

  1. Go to https://discuss.flarum.org/
  2. Click on "support" tag
  3. You will not see the tag description... You have to scroll up. All tags load with you scrolled down a little.

Expected Behavior The page should not start scrolled down on load.

Screenshots https://discuss.flarum.org/d/20774-opening-tag-page-starts-partially-scrolled-down

Environment

tobyzerner commented 5 years ago

This is intended behaviour to prevent the sidebar from being shifted down when you click on an item. https://github.com/flarum/core/blob/689d767f828c80c583135a56c9d334767908d0b5/js/src/forum/components/IndexPage.js#L101-L115

mikejones3 commented 5 years ago

@tobyzerner hmm then what is the point of the hero there at the top if it is not visible or only halfway visible.

I am not sure what you mean by sidebar jump around?

Ornanovitch commented 4 years ago

Hey and thanks to all of you, flarum dev team :)

I'm currently configuring a forum for my friends, and that behavior surprises me every time. I agree with @mikejones3 on this, it would be more user-friendly to see the tag hero when we enter in an other tag.

dsevillamartin commented 4 years ago

The problem Toby described was that the sidebar (list of tags, all discussions, subscribed, etc...) would jump and not be at the same position as the page would be scrolled up. So, if you clicked on a tag, your mouse would no longer be over the same button.

Just wanted to clarify this, as it looks like the behavior wasn't clear.

Ornanovitch commented 4 years ago

Ok thanks, I understand this point, it wasn't clear for me indeed..!