search

flarum / issue-archive

0 stars 0 forks source link

Three missing post events #273

Open jordanjay29 opened 6 years ago

jordanjay29 commented 6 years ago

The following post events are missing from Flarum Core/Approval:

Adding these would be very useful for moderation. I'd suggest that these post events be view-restricted to those with the permission to perform these events, too, because these are pretty much strictly moderation events that the public doesn't necessarily need to see who did them.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

stale[bot] commented 4 years ago

We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it.

dsevillamartin commented 4 years ago

We still want these.

askvortsov1 commented 4 years ago

@jordanjay29 from a cursory examination, this functionality seems to be largely covered.

https://github.com/flarum/approval/blob/master/src/Event/PostWasApproved.php provides approval

https://github.com/flarum/core/blob/master/src/Post/Event/Hidden.php provides soft delete

https://github.com/flarum/core/blob/master/src/Post/Event/Deleting.php and https://github.com/flarum/core/blob/master/src/Post/Event/Deleted.php provide hard delete.

Were you envisioning something beyond these for this issue?

jordanjay29 commented 4 years ago

Those are backend events, they're recorded, but there's no UI event in the frontend on the discussion itself. Much like Lock, Sticky, Tag change, Rename, etc have UI post events, these are also needed for Approval, Soft Delete/Hidden and Hard Delete.

askvortsov1 commented 4 years ago

Ah my bad lol, I've gotten so used to the backend I forgot the frontend has events too. I'll start work on this.

askvortsov1 commented 4 years ago

@jordanjay29, did you have a vision for the content of the post events? Right now I'm imagining something along the lines of:

"askvortsov permanently deleted/restored/approved askvortsov's post'

The usernames would be linked (need to figire out a. good way to include additional users in serialization). If hidden/restored/approved, the last part would link to the relevant post. If permanently deleted, tool tip hover would show post content.

This isn't ideal, so I was wondering if you had anything better.

askvortsov1 commented 4 years ago

I'm putting work on this on hold until I make some infrastructural changes to the post system

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!