ghost
commented
8 years ago After running into this issue today: flarum/framework#985
I'm permanently disabling Nginx cache in favor of Varnish for the API System.
Viewing the api docs it appears the best approach is to start by issuing a http purge request for every unsafe API call.
So for example:
POST /api/discussions - create a new discussion
PATCH /api/discussions/:id - update a discussion
DELETE /api/discussions/:id - delete a discussion
Would need generate a http purge upstream to varnish. This would be filtered through the VCL and expire the GET /api/discussions/:id - get a discussion by ID
@franzliedke mentioned doing away with the purge request altogether, by creating a rule to purge GET every time an unsafe request is made by a user. Could this work out? I think so, but what about the times when a request passes through Varnish, expiring some cache but the request isn't successful at the webapp? It would at least be an inefficiency, though wouldn't be likely to occur often. Could this lack of validation from the webapp cause any other issues?
This is a starting point, but what to do with objects that are shared outside this request? The next step appears to be utilizing the BAN function though to be entirely honest I'm not sure exactly how this would work.
See here for suggestions.
The gist is that there's at least a couple ways to go about getting varnish to know which objects in a request are shared and on which other pages. This gets fed back to a regex BANrule.
Going this route is more complicated than nginx, but more specific, and the safe way to cache dynamic content when the full page contains a mix of public/private data.
luceos
BartVB
dav-is
tobyzerner
stale[bot]
See: http://whitequark.org/blog/2014/04/05/page-caching-with-nginx/ http://apidock.com/rails/ActionController/ConditionalGet/stale%3F
Trying to think of the best way to do this... I guess on
Api\AbstractSerializeControllerwe can have some kind of method that returns an etag/last modified timestamp which thehandlemethod checks and returns the appropriate response. Then our subclass controllers can override that method to provide appropriate data.