search

flarum / issue-archive

0 stars 0 forks source link

Quotes and Codeblocks are hard to read with a dark scheme. #370

Open bwmarrin opened 8 years ago

bwmarrin commented 8 years ago

If you set the forums to use a dark scheme then quoted text and codeblocks become very hard to read. It does not look like there's a way to simply use a CSS setting to solve this problem easily without also effecting other colors.

By modifying the below two points I've been able to manually set a color to solve this on the two forums I have running.

https://github.com/flarum/core/blob/master/less/forum/Post.less#L111 https://github.com/flarum/core/blob/master/less/forum/Post.less#L122

I've adjusted them both, respectively, as shown below. This lets me just set the color in the custom CSS box.

background: @blockquote-bg;
...
background: @pre-bg;

Then I can use the Custom CSS box to add something like..

@blockquote-bg:  #ffffff;
@pre-bg:  #ffffff;
mattsterr commented 8 years ago

I think it's bigger than just the quotes and code blocks, look at these!! Almost impossible to read!

I'll try and work on some changes to sort this out and post them at some point.

image

image

dcsjapan commented 8 years ago

From what I've seen on Kulga's dev site, I'd agree that it needs much higher contrast in general.

I'm sort of hoping to use the dark scheme on our own site eventually, as a good light-on-dark scheme would be much easier on our aging eyes.

dsevillamartin commented 8 years ago

I think this has been partially fixed with the new code style of flarum/framework#936, screenshot:

It stands out more, so I guess we need to change the focus of this issue to the styling of quotes with the dark scheme.

PS: Why does this need verification?