[Flags] Optimization needed while handling large amounts of unattended flags

Hari-Bonda commented 3 years ago

Bug Report

This is not a bug maybe we can call it an enhancement/optimization

Current Behavior A clear and concise description of the behaviour.

i have almost 920 yet approve posts, when I hit the flag icon it's loading slowly 😅 is there any way to load it fastly? any better way to optimize it? I'm using Redis (sessions, cache, queue)

The flags extension loads all the flags and returns them, it assumes there can't be a situation where we could end up with such a crazy amount of unattended flags.

Steps to Reproduce make 1000 unapproved posts :)

Expected Behavior i have almost 920 yet approve posts, when I hit the flag icon it's loading slowly

Environment

Flarum version: 1.0.4
Website URL: N/A
Webserver: [apache]
Hosting environment: [vps]
PHP version: 7.4
Browser: [chrome]

Possible Solution

as it'd be better to paginate like the notifications, despite the fact that admins shouldn't normally have such a high number of flags.

https://discuss.flarum.org/d/28570-loading-issue-with-flags-920-pending-posts

askvortsov1 commented 3 years ago

Once we have the abstract paginated list component @datitisev has been working on, we should refactor all these lists to use it.

Hari-Bonda commented 2 years ago

🙋🏼‍♂️ could you consider adding this kind of page where we can view all unapproved discussions? I think that is the only solution where we can directly access all discussions on one page without hitting the flag button.

if we have a dedicated page that will get "load more" button we can simply request 20-30 posts by hitting it.

https://discuss.flarum.org/d/28570-loading-issue-with-flags-920-pending-posts/9

flarum / issue-archive

[Flags] Optimization needed while handling large amounts of unattended flags #53

Bug Report