[Likes][Mentions] Post control items order can change

SychO9 commented 3 years ago

This isn't a bug, but an annoyance.

People have reported multiple times that the items swap places. This happens whenever the enabled extensions order is resolved, I believe the order falls back to randomness, hence why mentions can sometimes load before likes and other times the other way around.

I see two possible solutions:

Explicitly set priorities for these items in JS side so that they're always ordered in the same way.
Change the extension boot order resolving to fallback to something, like the package name.

davwheat commented 3 years ago

I'm much more in favour of the first. It matches almost all other areas of core, where we tend to use priorities.

askvortsov1 commented 3 years ago

Tbh, I like the first one too. That being said, the frontend boot order should map to the backend one, and we should also change the backend one to sort alphabetically before sorting topologically so that boot order is deterministic.

flarum / issue-archive

[Likes][Mentions] Post control items order can change #54