flarum / issue-archive

0 stars 0 forks source link

[flags] complications with deleting event #68

Open luceos opened 3 years ago

luceos commented 3 years ago

The Deleting event in the flarum/flags extension was refactored here https://github.com/flarum/flags/pull/35.

As a consequence:

In addition, the original comment made by Ian (https://github.com/flarum/flags/pull/35#discussion_r563206641) - to me - isn't really, entirely valid. Our flags implementation dismisses all flags from a post when the flag(s) on that post are reviewed; it is one interaction that causes the dismissal of all flags of one post.

As such we need to remedy this by doing:

askvortsov1 commented 3 years ago

I like: