search

flash-oss / medici

Double-entry accounting system for nodejs + mongoose
MIT License
309 stars 85 forks source link

Drop node 6 support, replace .then() with async/await #13

Closed koresar closed 4 years ago

koresar commented 5 years ago

Looking for a volunteer to do it.

samuelt1 commented 5 years ago

I think I might do this, but how picky are you about pill requests? I have not contributed many times because the repository owner wanted all functions in alphabetical order.

koresar commented 5 years ago

all functions in alphabetical order.

ahahahaha! I have never heard of such a thing in my life (except in C# world). :)

I'm not at all picky. Just don't break existing stuff. :)

Also, if you contribute a meaningful PR I'd love to make you a maintainer of medici.

samuelt1 commented 5 years ago

sweet I will look into it then. I am going to use Medici then for my project. It will probably be like 1 month for my pull request, but I look forward to working with you.

koresar commented 5 years ago

I already like you! 😍

On Sat., 21 Sep. 2019, 06:10 Samuel Thompson, notifications@github.com wrote:

sweet I will look into it then. I am going to use Medici then for my project. It will probably be like 1 month for my pull request, but I look forward to working with you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/koresar/medici/issues/13?email_source=notifications&email_token=AAMMEL63YBUQYMBEQULPODDQKUU25A5CNFSM4H4XEMH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7HYFZI#issuecomment-533693157, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMMEL34PND7VVCWEZIIJH3QKUU25ANCNFSM4H4XEMHQ .

koresar commented 5 years ago

@samuelt1 any updates yet?

samuelt1 commented 5 years ago

I got distracted with other things. I am just starting to use your module now

koresar commented 5 years ago

Typical situation. 😀

On Wed., 30 Oct. 2019, 15:40 Samuel Thompson, notifications@github.com wrote:

I got distracted with other things. I am just starting to use your module now

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/koresar/medici/issues/13?email_source=notifications&email_token=AAMMEL3XZQ5HXLHL5VZLA5LQREF47A5CNFSM4H4XEMH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECS4V2I#issuecomment-547736297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMMEL4Y7CCEJOY542NBQTTQREF47ANCNFSM4H4XEMHQ .

koresar commented 4 years ago

v4.0.0 was published. The only change - use async/await everywhere. Drop node.js 6 support.