search

flash-oss / node_acl

Access control lists for node applications
MIT License
63 stars 9 forks source link

Update Mongodb to the new driver. #6

Closed harisvsulaiman closed 2 years ago

harisvsulaiman commented 2 years ago

This allow the acl lib to be used with the current driver. Mongodb atlas will auto-upgrade to mongodb 5.0 on February, I am hoping to get this merged before that.

koresar commented 2 years ago

Hello. Thanks for the contribution mate! Overall, the PR is good. Merging right now. I have few minor questions though. I'll ask them separately.

Also, I've granted you Write access to this repo. :) Feel free to push directly to it.

koresar commented 2 years ago
  1. Tests fail under node 10.
  2. This better be a SemVer MAJOR then.
  3. We should probably drop mongodb v3.6 and leave support for mongodb >= v4.
  4. Need to amend CI to test under node 16 as well.
  5. I'll also try it under both mongodb driver versions 3 and 4.

Future:

  1. Time to move to Promises interface.
  2. Time to add sessions (aka ACID transactions).
koresar commented 2 years ago

Since the CI fails I'll force-merge it to a new branch and we'll go from there.

koresar commented 2 years ago

Released as v3.0.0. Now supports both mongodb drivers v3 and v4. https://github.com/flash-oss/node_acl/releases/tag/v3.0.0