search

flashbots / andromeda-sirrah-contracts

forge development env for SUAVE key management
MIT License
19 stars 5 forks source link

fix Auction.t.sol: set block.height > auctionEndTime before calling *_Finalize() #29

Closed maceip closed 9 months ago

maceip commented 9 months ago

as is they are equal and this test will revert (is this intended?)

    ├─ [1177] SealedAuction::offchain_Finalize()
    │   ├─ [0] console::log(" block.height%d:  auctionEndTime: %d", 3, 3) [staticcall]
    │   │   └─ ← ()
    │   └─ ← EvmError: Revert
    └─ ← EvmError: Revert
amiller commented 9 months ago

Thanks for spotting this, reproduces for me. From going back and testing earlier commits, this is the first place where it fails for me: https://github.com/flashbots/andromeda-sirrah-contracts/commit/15fe34a5f38bff034a2ff7d476b711b682baed97#diff-e4968bf602872e2fb7d46c267abf764416f6e1bf47519eb8e48b45a6428a6213 sure enough that adds some new logic on delays