flashbots / ethers-provider-flashbots-bundle

Flashbots provider for ethers.js
545 stars 213 forks source link

implement sendPrivateTransaction function #66

Closed zeroXbrock closed 2 years ago

zeroXbrock commented 2 years ago

@taarushv @bertmiller @metachris @bhakiyakalimuthu

krasi-georgiev commented 2 years ago

I would really appreciate it if the team also includes this on goerli so that we can write some CI testing for the flashbot libraries or suggest some other way to ensure the json request and response parsing works as expected.

Otherwise as you can see even in this PR we add new futures without any tests in the CI

I am the maintainer of https://github.com/cryptoriums/flashbot

wong2 commented 2 years ago

wen merge?

zeroXbrock commented 2 years ago

I would really appreciate it if the team also includes this on goerli so that we can write some CI testing for the flashbot libraries or suggest some other way to ensure the json request and response parsing works as expected.

Otherwise as you can see even in this PR we add new futures without any tests in the CI

I am the maintainer of https://github.com/cryptoriums/flashbot

thanks for the comment @krasi-georgiev. @bhakiyakalimuthu might be able to offer more insight on whether/when we'll have private txs on Goerli. It requires extra infra so it's a bit more time-consuming to implement than one might expect.

At any rate, you'll probably be better off using mock data instead of testing against Goerli. Goerli can be unreliable enough as it is, not to mention very slow (although I suppose that's not a huge deal in CI). My two cents, anyways :)

zeroXbrock commented 2 years ago

wen merge?

v soon