search

flashbots / mev-boost-relay

MEV-Boost Relay for Ethereum proposer/builder separation (PBS)
https://boost-relay.flashbots.net
GNU Affero General Public License v3.0
413 stars 116 forks source link

Feature request: additional precision for log timestamps #528

Open alextes opened 1 year ago

alextes commented 1 year ago

It seems current log lines add timestamps with second-level precision. In our logging infra this results in thousands of logs sharing the same timestamp which hurts our ability to look at the order of logs. One can drill down on log specific, precise timestamps as infra allows but this loses ordering between log types still.

Open to a PR flipping on precise timestamps? Was this left at the current precision intentionally perhaps?

From what I read logrus accepts go time formats, so setting TimestampFormat to time.RFC3339Nano could be nice, which would provide nanosecond level timestamps.

metachris commented 12 months ago

We could discuss changing the timestamp format to RFC3339Nano! Could you open a PR? Then we can circulate this across the broader boost relay community and ask for input, I don't see a blocker right away.

metachris commented 12 months ago

timestamps may be a bit easier to parse though, not sure if some operators have a strong opinion of timestamp in milliseconds vs RFC3339Nano 🤔 let's start a conversation!

alextes commented 11 months ago

Created a PR: https://github.com/flashbots/mev-boost-relay/pull/537 👍