flashbots / mev-boost-relay

MEV-Boost Relay for Ethereum proposer/builder separation (PBS)
https://boost-relay.flashbots.net
GNU Affero General Public License v3.0
422 stars 119 forks source link

Decouple logic and periodic scheduling from internal tasks #633

Closed ferranbt closed 4 months ago

ferranbt commented 4 months ago

📝 Summary

This PR decouples some internal logic in Housekeeper and API in two functions, one with the core logic and another one that decides whether the core logic is executed or not given the slot.

📚 References


✅ I have run these commands

metachris commented 4 months ago

I think the direction makes sense. I feel it's a bit confusing to split these up into a function with the same name but BySlot suffix, when really it does the execution but without the prechecks.

I would prefer to be more explicit and use WithoutChecks as suffix.