flashbots / mev-boost

MEV-Boost allows Ethereum validators to source high-MEV blocks from a competitive builder marketplace
https://boost.flashbots.net
MIT License
1.13k stars 198 forks source link

common: simplify floatToEth #639

Closed MariusVanDerWijden closed 3 months ago

MariusVanDerWijden commented 3 months ago

Simplify the FloatEthTo256Wei calculation. The trick with converting to string is still kinda ugly imo

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.28%. Comparing base (8b662e0) to head (9316bf3).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #639 +/- ## =========================================== - Coverage 52.37% 52.28% -0.09% =========================================== Files 14 14 Lines 1600 1597 -3 =========================================== - Hits 838 835 -3 Misses 703 703 Partials 59 59 ``` | [Flag](https://app.codecov.io/gh/flashbots/mev-boost/pull/639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flashbots/mev-boost/pull/639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `52.28% <100.00%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.