search

flashbots / mev-boost

MEV-Boost allows Ethereum validators to source high-MEV blocks from a competitive builder marketplace
https://boost.flashbots.net
MIT License
1.13k stars 198 forks source link

Adding a cli library #640

Open MariusVanDerWijden opened 3 months ago

MariusVanDerWijden commented 3 months ago

Would you be open to move the cli/flags handling from the basic-builtin handling to some library?

ralexstokes commented 3 months ago

I'd support this, esp for the right library -- is there one you have in mind?

I assume the intent is to simplify or harden the current flags infrastructure?

MariusVanDerWijden commented 3 months ago

Yes exactly, I would use https://github.com/urfave/cli which is the one we use in go-ethereum. Theres a lot of dereferencing of flags going on which feels a bit unsafe