search

flashbots / mev-boost

MEV-Boost allows Ethereum validators to source high-MEV blocks from a competitive builder marketplace
https://boost.flashbots.net
MIT License
1.13k stars 198 forks source link

cli: refactor sanitizeMinBid #641

Closed MariusVanDerWijden closed 3 months ago

MariusVanDerWijden commented 3 months ago

Refactor sanitizeMinBid

MariusVanDerWijden commented 3 months ago

The linter fails, because it complains about dynamic errors and enforces static errors. I kinda disagree with the linter. Declaring static errors makes everything more spaghetti and this method is not used from a context where the type checking you get with static errors is useful. I am going to declare them as static anyway, to make the linter happy, but I think it makes the code worse and you should consider disabling the err113 check

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 52.30%. Comparing base (8b662e0) to head (8099445).

Files Patch % Lines
cli/main.go 0.00% 13 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #641 +/- ## =========================================== - Coverage 52.37% 52.30% -0.07% =========================================== Files 14 14 Lines 1600 1602 +2 =========================================== Hits 838 838 - Misses 703 706 +3 + Partials 59 58 -1 ``` | [Flag](https://app.codecov.io/gh/flashbots/mev-boost/pull/641/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flashbots/mev-boost/pull/641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `52.30% <0.00%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.